Browse Source

The signature for `yii\gridview\ActionColumn::urlCreator` is changed - the `$action` parameter is moved to the first

tags/2.0.0-beta
Qiang Xue 11 years ago
parent
commit
bae5cda5b9
  1. 1
      framework/CHANGELOG.md
  2. 6
      framework/yii/grid/ActionColumn.php

1
framework/CHANGELOG.md

@ -38,6 +38,7 @@ Yii Framework 2 Change Log
- Chg: Renamed `ActiveRecord::getPopulatedRelations()` to `getRelatedRecords()` (qiangxue) - Chg: Renamed `ActiveRecord::getPopulatedRelations()` to `getRelatedRecords()` (qiangxue)
- Chg: Renamed `attributeName` and `className` to `targetAttribute` and `targetClass` for `UniqueValidator` and `ExistValidator` (qiangxue) - Chg: Renamed `attributeName` and `className` to `targetAttribute` and `targetClass` for `UniqueValidator` and `ExistValidator` (qiangxue)
- Chg: Added `yii\widgets\InputWidget::options` (qiangxue) - Chg: Added `yii\widgets\InputWidget::options` (qiangxue)
- Chg: The signature for `yii\gridview\ActionColumn::urlCreator` is changed - the `$action` parameter is moved to the first (qiangxue)
- New #1438: [MongoDB integration](https://github.com/yiisoft/yii2-mongodb) ActiveRecord and Query (klimov-paul) - New #1438: [MongoDB integration](https://github.com/yiisoft/yii2-mongodb) ActiveRecord and Query (klimov-paul)
- New #1393: [Codeception testing framework integration](https://github.com/yiisoft/yii2-codeception) (Ragazzo) - New #1393: [Codeception testing framework integration](https://github.com/yiisoft/yii2-codeception) (Ragazzo)

6
framework/yii/grid/ActionColumn.php

@ -70,16 +70,16 @@ class ActionColumn extends Column
} }
/** /**
* @param string $action
* @param \yii\db\ActiveRecord $model * @param \yii\db\ActiveRecord $model
* @param mixed $key the key associated with the data model * @param mixed $key the key associated with the data model
* @param integer $index * @param integer $index
* @param string $action
* @return string * @return string
*/ */
public function createUrl($model, $key, $index, $action) public function createUrl($action, $model, $key, $index)
{ {
if ($this->urlCreator instanceof Closure) { if ($this->urlCreator instanceof Closure) {
return call_user_func($this->urlCreator, $model, $key, $index, $action); return call_user_func($this->urlCreator, $action, $model, $key, $index);
} else { } else {
$params = is_array($key) ? $key : ['id' => $key]; $params = is_array($key) ? $key : ['id' => $key];
$route = $this->controller ? $this->controller . '/' . $action : $action; $route = $this->controller ? $this->controller . '/' . $action : $action;

Loading…
Cancel
Save