Fixes #98: Fixed `yii\bootstrap\ButtonDropdown` setting `href` attribute for non `a` tags

9 years ago · e7b4df436f
2 changed files with 2 additions and 2 deletions
--- a/ButtonDropdown.php
+++ b/ButtonDropdown.php
@ -113,7 +113,7 @@ class ButtonDropdown extends Widget
        } else {
            $label .= ' <span class="caret"></span>';
            $options = $this->options;
-            if (!isset($options['href'])) {
+            if (!isset($options['href']) && $this->tagName === 'a') {
                $options['href'] = '#';
            }
            Html::addCssClass($options, ['toggle' => 'dropdown-toggle']);
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -4,7 +4,7 @@ Yii Framework 2 bootstrap extension Change Log
 2.0.6 under development
 -----------------------
-
+- Bug #98: Fixed `yii\bootstrap\ButtonDropdown` setting `href` attribute for non `a` tags (13nightevil)
 2.0.5 September 23, 2015
 ------------------------