From 0ee120f5f939a4ad8b0e5b332b6818a078666ce4 Mon Sep 17 00:00:00 2001
From: Qiang Xue <qiang.xue@gmail.com>
Date: Tue, 29 Oct 2013 23:17:50 -0400
Subject: [PATCH] refactored Component::off().

---
 framework/yii/base/Component.php | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/framework/yii/base/Component.php b/framework/yii/base/Component.php
index 9d5258a..1d26dd7 100644
--- a/framework/yii/base/Component.php
+++ b/framework/yii/base/Component.php
@@ -406,24 +406,25 @@ class Component extends Object
 	public function off($name, $handler = null)
 	{
 		$this->ensureBehaviors();
-		if (isset($this->_events[$name])) {
-			if ($handler === null) {
-				$this->_events[$name] = [];
-			} else {
-				$removed = false;
-				foreach ($this->_events[$name] as $i => $event) {
-					if ($event[0] === $handler) {
-						unset($this->_events[$name][$i]);
-						$removed = true;
-					}
-				}
-				if ($removed) {
-					$this->_events[$name] = array_values($this->_events[$name]);
+		if (empty($this->_events[$name])) {
+			return false;
+		}
+		if ($handler === null) {
+			unset($this->_events[$name]);
+			return true;
+		} else {
+			$removed = false;
+			foreach ($this->_events[$name] as $i => $event) {
+				if ($event[0] === $handler) {
+					unset($this->_events[$name][$i]);
+					$removed = true;
 				}
-				return $removed;
 			}
+			if ($removed) {
+				$this->_events[$name] = array_values($this->_events[$name]);
+			}
+			return $removed;
 		}
-		return false;
 	}
 
 	/**