From 389c0e2bb67879a794ac34e3e7d619432d198ecf Mon Sep 17 00:00:00 2001 From: Qiang Xue Date: Wed, 10 Jul 2013 13:24:04 -0400 Subject: [PATCH] Improved log panel display. --- framework/yii/base/Action.php | 2 +- framework/yii/base/InlineAction.php | 2 +- framework/yii/debug/panels/LogPanel.php | 21 ++++++++++----------- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/framework/yii/base/Action.php b/framework/yii/base/Action.php index 429d074..1a56cec 100644 --- a/framework/yii/base/Action.php +++ b/framework/yii/base/Action.php @@ -77,7 +77,7 @@ class Action extends Component throw new InvalidConfigException(get_class($this) . ' must define a "run()" method.'); } $args = $this->controller->bindActionParams($this, $params); - Yii::info('Running "' . get_class($this) . '::run()" with parameters: ' . var_export($args, true), __METHOD__); + Yii::info('Running action: ' . get_class($this) . '::run()', __METHOD__); if (Yii::$app->requestedParams === null) { Yii::$app->requestedParams = $args; } diff --git a/framework/yii/base/InlineAction.php b/framework/yii/base/InlineAction.php index 3a12bc8..561fd1a 100644 --- a/framework/yii/base/InlineAction.php +++ b/framework/yii/base/InlineAction.php @@ -46,7 +46,7 @@ class InlineAction extends Action public function runWithParams($params) { $args = $this->controller->bindActionParams($this, $params); - Yii::info("Running '" . get_class($this->controller) . '::' . $this->actionMethod . "()' with parameters: " . var_export($args, true), __METHOD__); + Yii::info('Running action: ' . get_class($this->controller) . '::' . $this->actionMethod . '()', __METHOD__); if (Yii::$app->requestedParams === null) { Yii::$app->requestedParams = $args; } diff --git a/framework/yii/debug/panels/LogPanel.php b/framework/yii/debug/panels/LogPanel.php index b2efde1..e84bec2 100644 --- a/framework/yii/debug/panels/LogPanel.php +++ b/framework/yii/debug/panels/LogPanel.php @@ -26,26 +26,25 @@ class LogPanel extends Panel public function getSummary() { - $output = array(); + $output = array('' . count($this->data['messages']) . ''); + $title = 'Logged ' . count($this->data['messages']) . ' messages'; $errorCount = count(Target::filterMessages($this->data['messages'], Logger::LEVEL_ERROR)); if ($errorCount) { - $output[] = '' . $errorCount . ' ' . ($errorCount > 1 ? 'errors' : 'error'); + $output[] = '' . $errorCount . ''; + $title .= ", $errorCount errors"; } $warningCount = count(Target::filterMessages($this->data['messages'], Logger::LEVEL_WARNING)); if ($warningCount) { - $output[] = '' . $warningCount . ' ' . ($warningCount > 1 ? 'warnings' : 'warning'); + $output[] = '' . $warningCount . ''; + $title .= ", $warningCount warnings"; } - if (!empty($output)) { - $log = implode(', ', $output); - $url = $this->getUrl(); - return <<getUrl(); + return << - $log + Log: $log EOD; - } else { - return ''; - } } public function getDetail()