From c294e033b3b3c74cc2cd4d8510283d8359ee4755 Mon Sep 17 00:00:00 2001
From: Paul Klimov <klimov.paul@gmail.com>
Date: Mon, 2 Dec 2013 16:23:20 +0200
Subject: [PATCH] Unit test for "yii\mongo\Collection::mapReduce()" added.

---
 extensions/mongo/Collection.php                | 17 ++++++++++++++--
 tests/unit/extensions/mongo/CollectionTest.php | 27 ++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/extensions/mongo/Collection.php b/extensions/mongo/Collection.php
index daa3ff1..a9e6f0a 100644
--- a/extensions/mongo/Collection.php
+++ b/extensions/mongo/Collection.php
@@ -216,7 +216,9 @@ class Collection extends Object
 
 	/**
 	 * Performs aggregation using Mongo Map Reduce mechanism.
-	 * @param mixed $keys
+	 * @param mixed $keys fields to group by. If an array or non-code object is passed,
+	 * it will be the key used to group results. If instance of [[\MongoCode]] passed,
+	 * it will be treated as a function that returns the key to group by.
 	 * @param array $initial Initial value of the aggregation counter object.
 	 * @param \MongoCode|string $reduce function that takes two arguments (the current
 	 * document and the aggregation to this point) and does the aggregation.
@@ -225,6 +227,7 @@ class Collection extends Object
 	 *  - condition - criteria for including a document in the aggregation.
 	 *  - finalize - function called once per unique key that takes the final output of the reduce function.
 	 * @return array the result of the aggregation.
+	 * @see http://docs.mongodb.org/manual/core/map-reduce/
 	 */
 	public function mapReduce($keys, $initial, $reduce, $options = [])
 	{
@@ -239,7 +242,17 @@ class Collection extends Object
 				$options['finalize'] = new \MongoCode((string)$options['finalize']);
 			}
 		}
-		return $this->mongoCollection->group($keys, $initial, $reduce, $options);
+		// Avoid possible E_DEPRECATED for $options:
+		if (empty($options)) {
+			$result = $this->mongoCollection->group($keys, $initial, $reduce);
+		} else {
+			$result = $this->mongoCollection->group($keys, $initial, $reduce, $options);
+		}
+		if (array_key_exists('retval', $result)) {
+			return $result['retval'];
+		} else {
+			return [];
+		}
 	}
 
 	/**
diff --git a/tests/unit/extensions/mongo/CollectionTest.php b/tests/unit/extensions/mongo/CollectionTest.php
index 1e86236..f7d8090 100644
--- a/tests/unit/extensions/mongo/CollectionTest.php
+++ b/tests/unit/extensions/mongo/CollectionTest.php
@@ -145,4 +145,31 @@ class CollectionTest extends MongoTestCase
 		list($row) = $collection->findAll();
 		$this->assertEquals($newData['name'], $row['name']);
 	}
+
+	/**
+	 * @depends testBatchInsert
+	 */
+	public function testMapReduce()
+	{
+		$collection = $this->getConnection()->getCollection('customer');
+		$rows = [
+			[
+				'name' => 'customer 1',
+				'address' => 'customer 1 address',
+			],
+			[
+				'name' => 'customer 2',
+				'address' => 'customer 2 address',
+			],
+		];
+		$collection->batchInsert($rows);
+
+		$keys = ['address' => 1];
+		$initial = ['items' => []];
+		$reduce = "function (obj, prev) { prev.items.push(obj.name); }";
+		$result = $collection->mapReduce($keys, $initial, $reduce);
+		$this->assertEquals(2, count($result));
+		$this->assertNotEmpty($result[0]['address']);
+		$this->assertNotEmpty($result[0]['items']);
+	}
 }
\ No newline at end of file