You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 

767 B

Yii2 core code style

Proposals

Brackets

It's better to be consistent with brackets not to remember where should we use newline and where not:

class MyClass
{
	public function myClassMethod()
	{
		if($x) {
			// do it
		} else {
			// some code
		}
	}
}

Use brackets even for one line ifs.

I chose to use the style as shown in Component.php because I want to make the curly brackets consistent with array brackets regarding newlines. Similar coding style is also used in Symfony 2.

Use type hinting like

public function __construct(CDbConnection $connection)
{
	$this->connection = $connection;
}

instead of

public function __construct($connection)
{
	$this->connection = $connection;
}