Fix #17762: PHP 7.4: Remove special condition for converting PHP errors to exceptions if they occurred inside of `__toString()` call

framework/CHANGELOG.md

@@ -5,6 +5,7 @@ Yii Framework 2 Change Log
 ------------------------
 
 - Bug #17744: Fix a bug with setting incorrect `defaultValue` to AR column with `CURRENT_TIMESTAMP(x)` as default expression (MySQL >= 5.6.4) (bizley)
+- Bug #17762: PHP 7.4: Remove special condition for converting PHP errors to exceptions if they occurred inside of `__toString()` call (rob006)
 
 
 2.0.31 December 18, 2019

framework/base/ErrorHandler.php

@@ -212,16 +212,18 @@ abstract class ErrorHandler extends Component
             }
             $exception = new ErrorException($message, $code, $code, $file, $line);
 
-            // in case error appeared in __toString method we can't throw any exception
-            $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
-            array_shift($trace);
-            foreach ($trace as $frame) {
-                if ($frame['function'] === '__toString') {
-                    $this->handleException($exception);
-                    if (defined('HHVM_VERSION')) {
-                        flush();
+            if (PHP_VERSION_ID < 70400) {
+                // prior to PHP 7.4 we can't throw exceptions inside of __toString() - it will result a fatal error
+                $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
+                array_shift($trace);
+                foreach ($trace as $frame) {
+                    if ($frame['function'] === '__toString') {
+                        $this->handleException($exception);
+                        if (defined('HHVM_VERSION')) {
+                            flush();
+                        }
+                        exit(1);
                     }
-                    exit(1);
                 }
             }