Optimized forms code a bit

apps/advanced/common/models/User.php

@@ -129,7 +129,10 @@ class User extends ActiveRecord implements IdentityInterface
 	public function rules()
 	{
 		return [
+			['status', 'default', 'value' => self::STATUS_ACTIVE],
 			['status', 'in', 'range' => [self::STATUS_ACTIVE, self::STATUS_DELETED]],
+
+			['role', 'default', 'value' => self::ROLE_USER],
 			['role', 'in', 'range' => [self::ROLE_USER]],
 
 			['username', 'filter', 'filter' => 'trim'],

apps/advanced/frontend/models/forms/ResetPasswordForm.php

@@ -58,13 +58,9 @@ class ResetPasswordForm extends Model
 	public function resetPassword()
 	{
 		$user = $this->_user;
-		if ($user->validate()) {
+		$user->password = $this->password;
-			$user->password = $this->password;
+		$user->removePasswordResetToken();
-			$user->removePasswordResetToken();
+		return $user->save();
-			return $user->save();
-		} else {
-			return false;
-		}
 	}
 }
  

apps/advanced/frontend/models/forms/SignupForm.php

@@ -41,13 +41,7 @@ class SignupForm extends Model
 	public function signup()
 	{
 		if ($this->validate()) {
-			$user = new User();
+			$user = User::create($this->attributes);
-			$user->username = $this->username;
-			$user->email = $this->email;
-			$user->password = $this->password;
-			$user->generatePasswordResetToken();
-			$user->role = User::ROLE_USER;
-			$user->status = User::STATUS_ACTIVE;
 			if ($user->save()) {
 				return $user;
 			}

framework/db/BaseActiveRecord.php

@@ -986,8 +986,6 @@ abstract class BaseActiveRecord extends Model implements ActiveRecordInterface
 	/**
 	 * Creates an active record object using a row of data from the database/storage.
 	 *
-	 * This method is *not* meant to be used to create new records.
-	 *
 	 * It is an internal method meant to be called to create active record objects after
 	 * fetching data from the database. It is mainly used by [[ActiveQuery]] to populate
 	 * the query results into Active Records.