possible fix for gridview checkall name

https://github.com/yiisoft/yii/issues/3810

framework/grid/CheckboxColumn.php

@@ -91,7 +91,16 @@ class CheckboxColumn extends Column
      */
     protected function renderHeaderCellContent()
     {
-        $name = rtrim($this->name, '[]') . '_all';
+        $name = $this->name;
+        if (substr_compare($name, '[]', -2, 2) === 0) {
+            $name = substr($name, 0, -2);
+        }
+        if (substr_compare($name, ']', -1, 1) === 0) {
+            $name =  substr($name, 0, -1) . '_all]';
+        } else {
+            $name .= '_all';
+        }
+
         $id = $this->grid->options['id'];
         $options = json_encode([
             'name' => $this->name,

tests/unit/framework/grid/CheckboxColumnTest.php

@@ -0,0 +1,63 @@
+<?php
+/**
+ * @link http://www.yiiframework.com/
+ * @copyright Copyright (c) 2008 Yii Software LLC
+ * @license http://www.yiiframework.com/license/
+ */
+
+namespace yiiunit\framework\grid;
+
+use yii\data\ArrayDataProvider;
+use yii\grid\CheckboxColumn;
+use yii\grid\GridView;
+use yii\helpers\FileHelper;
+use yii\i18n\Formatter;
+use yii\web\View;
+use Yii;
+use yiiunit\TestCase;
+
+/**
+ * @group grid
+ */
+class CheckboxColumnTest extends TestCase
+{
+    protected function setUp()
+    {
+        parent::setUp();
+        $this->mockApplication();
+        Yii::setAlias('@webroot', '@yiiunit/runtime');
+        Yii::setAlias('@web', 'http://localhost/');
+        FileHelper::createDirectory(Yii::getAlias('@webroot/assets'));
+    }
+
+    public function testInputName()
+    {
+        $column = new CheckboxColumn(['name' => 'selection', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="selection_all"', $column->renderHeaderCell());
+
+        $column = new CheckboxColumn(['name' => 'selections[]', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="selections_all"', $column->renderHeaderCell());
+
+        $column = new CheckboxColumn(['name' => 'MyForm[grid1]', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="MyForm[grid1_all]"', $column->renderHeaderCell());
+
+        $column = new CheckboxColumn(['name' => 'MyForm[grid1][]', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="MyForm[grid1_all]"', $column->renderHeaderCell());
+
+        $column = new CheckboxColumn(['name' => 'MyForm[grid1][key]', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="MyForm[grid1][key_all]"', $column->renderHeaderCell());
+
+        $column = new CheckboxColumn(['name' => 'MyForm[grid1][key][]', 'grid' => $this->getGrid()]);
+        $this->assertContains('name="MyForm[grid1][key_all]"', $column->renderHeaderCell());
+    }
+
+    /**
+     * @return GridView a mock gridview
+     */
+    protected function getGrid()
+    {
+        return new GridView([
+            'dataProvider' => new ArrayDataProvider(['allModels' => [], 'totalCount' => 0]),
+        ]);
+    }
+}