From f9041646ddaac6760b727a4fdc6d3e37705e69ef Mon Sep 17 00:00:00 2001 From: Kolyunya Date: Sun, 5 Mar 2017 14:27:13 +0300 Subject: [PATCH] Improve string validator test coverage --- tests/framework/validators/StringValidatorTest.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/framework/validators/StringValidatorTest.php b/tests/framework/validators/StringValidatorTest.php index 3f6100f..eadf4fa 100644 --- a/tests/framework/validators/StringValidatorTest.php +++ b/tests/framework/validators/StringValidatorTest.php @@ -22,6 +22,8 @@ class StringValidatorTest extends TestCase $val = new StringValidator(); $this->assertFalse($val->validate(['not a string'])); $this->assertTrue($val->validate('Just some string')); + $this->assertFalse($val->validate(true)); + $this->assertFalse($val->validate(false)); } public function testValidateValueLength() @@ -70,6 +72,12 @@ class StringValidatorTest extends TestCase $model->attr_string = 'a tet string'; $val->validateAttribute($model, 'attr_string'); $this->assertFalse($model->hasErrors()); + $model->attr_string = true; + $val->validateAttribute($model, 'attr_string'); + $this->assertTrue($model->hasErrors()); + $model->attr_string = false; + $val->validateAttribute($model, 'attr_string'); + $this->assertTrue($model->hasErrors()); $val = new StringValidator(['length' => 20]); $model = new FakedValidationModel(); $model->attr_string = str_repeat('x', 20);